[Cache] Custom pool #12904
Closed
[Cache] Custom pool #12904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nyholm could you please give a review here? Thanks 🙏 |
Nyholm
suggested changes
Jan 30, 2020
| cache.acme: | ||
| adapter: cache.adapter.memcached | ||
| cache.foobar: | ||
| adapter: cache.adapter.memcached | ||
| provider: 'memcached://user:password@example.com' | ||
|
|
||
| services: | ||
| app.my_cache_chain_adapter: |
There was a problem hiding this comment.
There is no need to introduce a cache chain here. It i explained later.
javiereguiluz
added a commit
that referenced
this pull request
Mar 12, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [Cache] Custom pool Hi everyone 👋 It seems that when defining a custom pool, the documenation is talking about an array adapter when the used one is the filesystem, the question is, do we need to reword it as filesystem in the text of change the code? 🤔 Thanks for the feedback 🙂 Commits ------- a50bce3 [FIX] Custom pool
|
Guillaume, thanks for this ... but at the end we decided to follow Tobias suggestion and change instead the text description and keep the original code. Thanks! |
|
No problem @javiereguiluz, sorry for the delay, I was working on something else and I've forgot this PR, really sorry 🙁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone 👋
It seems that when defining a custom pool, the documenation is talking about an array adapter when the used one is the filesystem, the question is, do we need to reword it as filesystem in the text of change the code? 🤔
Thanks for the feedback 🙂